Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unvendorable [%blob] path #1

Open
wants to merge 1 commit into
base: odoc_3_compat_clean
Choose a base branch
from
Open

Fix unvendorable [%blob] path #1

wants to merge 1 commit into from

Conversation

Julow
Copy link

@Julow Julow commented Dec 10, 2024

The path relative to the project root makes sherlodoc impossible to vendor. Use a relative path instead.

This makes sherlodoc vendorable: art-w#44

@Julow
Fix unvendorable [%blob] path
184fc92 
The path relative to the project root makes sherlodoc impossible to
vendor. Use a relative path instead.
@panglesd
Copy link
Owner

Looks good, but I'd like to test it a bit on various setups (from experience, the path from which ppx_blob starts depends on the version of dune/ocaml/ppx_blob...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Julow @panglesd